Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable collection on Geocoder::reverse #106

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

rewebcan
Copy link
Contributor

@rewebcan rewebcan commented May 13, 2024

There is a problem in my case I think reverseQuery does not return a correct Collection and it causes the problem below;

Update: I can confirm that if the Google Maps API Key is limited because of the issued Credit Card has expired, you get an empty collection.

image

Heyian added a commit to Heyian/filament-google-maps that referenced this pull request Aug 28, 2024
Heyian added a commit to Heyian/filament-google-maps that referenced this pull request Aug 28, 2024
@Heyian
Copy link
Collaborator

Heyian commented Aug 28, 2024

Hey there. I've merged this PR onto my fork so we can all get all these goodies from a single place. I gave credits to the person who made the PR in the commits, changelog and in the releases.
I've also credited cheesegrits for his work on the repo and made it clear this was a fork on top of the Readme. I'm not trying to hijack anything, I just want to be able to use all the good solutions people put in the pull requests and I thought I'd made this available to all. If you're interested in this version or want to contribute, you can find my fork at : Heyian/forkMain

I'm open to suggestions on how to move forward from here, simply open up an issue in my fork so we can chat about it.
Thanks.

@cheesegrits cheesegrits merged commit 9b314ec into cheesegrits:v3 Nov 15, 2024
@cheesegrits
Copy link
Owner

I'm working with @Heyian to get this package back up to date. I had some serious medical issues this year that took me out of circulation. But I'm back and (more or less) well again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants