feat: Use cheerio-select, to support positional selectors
#1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to get support for `Set`.
fb55
commented
Dec 15, 2020
| @@ -4,7 +4,7 @@ | |||
| }, | |||
| "plugins": ["jsdoc"], | |||
| "extends": ["eslint:recommended", "prettier"], | |||
| "globals": {}, | |||
| "globals": { "Set": true }, | |||
There was a problem hiding this comment.
Set has been supported since node 0.12. The minimum node version has been bumped to support this.
fb55
commented
Dec 15, 2020
| }, | ||
| "dependencies": { | ||
| "css-select": "^3.1.2", | ||
| "cheerio-select": "github:cheeriojs/cheerio-select", |
There was a problem hiding this comment.
We have a Github reference here, until cheeriojs/cheerio-select#2 is resolved.
fb55
commented
Dec 15, 2020
| // var $h2 = cheerio('<h2>fruits</h2>'); | ||
| // console.log($elem.before('hi')); | ||
| // console.log($elem.before($h2)); | ||
| it('should select first element cheerio(:first)', function () { |
There was a problem hiding this comment.
The test that has been skipped for forever is now finally live 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for jQuery positional selectors (:eq, :first, :not(:last) etc.).
Fixes #1355
Fixes #129