-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cheerio 1.0.0 breaks bundling of react native #4032
Comments
We're using turtle cli to do builds with React Native and error with the new Cheerio 1.0.0 release. There doesn't appear to be a way to change the package.json that turtle uses internally for the React Native build. If anyone has a work around for this please let me know. |
same error |
This new tag should've been released with 2.x.x instead of 1.x.x Auto upgrade from stable 1.0.0-rc.12 to 1.0.0 causes issues due to node version (node:: imports are not supported in node 14) @grahamrb and to anyone else facing this issue: I recommend you to ADD FIXED version set to the previous version in your dependencies/devDependencies of package.json so that any internal packages importing this package inherit this from your parent app : "devDependencies": { use below command to verify that any internal dependency is inheriting the package from parent ( in my case it was enzyme ) npm ls cheerio ├── [email protected] |
I am also experiencing this error when upgrading: |
cheerio (https://github.com/cheeriojs/cheerio) has release an official 1.0.0 version after years of Release Candidate ones. cheeriojs/cheerio#4044 cheeriojs/cheerio#4032 cheeriojs/cheerio#3987 We depend on enzyme (https://github.com/enzymejs/enzyme) which depends on cheerio. Enzyme has not correctly locked cheerio RC version: enzymejs/enzyme@cafdb2b They're working on it... enzymejs/enzyme#2558 enzymejs/enzyme#2606 enzymejs/enzyme#2607 enzymejs/enzyme#2608 enzymejs/enzyme#2609 Meanwhile, locking cheerio here allow us to update our dependencies. According to enzyme, Cheerio RC was the last one supported by enzyme, even though RC12 seems to work for us.
cheerio (https://github.com/cheeriojs/cheerio) has released an official 1.0.0 version after years of Release Candidate ones. cheeriojs/cheerio#4044 cheeriojs/cheerio#4032 cheeriojs/cheerio#3987 We depend on enzyme (https://github.com/enzymejs/enzyme) which depends on cheerio. Enzyme has not correctly locked cheerio RC version: enzymejs/enzyme@cafdb2b They're working on it... enzymejs/enzyme#2558 enzymejs/enzyme#2606 enzymejs/enzyme#2607 enzymejs/enzyme#2608 enzymejs/enzyme#2609 Meanwhile, locking cheerio here allow us to update our dependencies. According to enzyme, Cheerio RC was the last one supported by enzyme, even though RC12 seems to work for us.
Reverting to 1.0.0-rc.12 should fix issue |
same issue. I hope to fix this issue |
Tried to build with eas on expo to ios with simulator set to true, the error happened with the cheerio set to: ^1.0.0-rc.12 To run the build on android emulator with: ^1.0.0 or ^1.0.0-rc.12 the error happens Hope that helps someone and the possible fix #4033 |
Minimal example: https://github.com/thu-info-community/thu-info-app/actions/runs/10414518614/job/28843638237?pr=587
Steps to reproduce:
The text was updated successfully, but these errors were encountered: