Add support for Rails 7.2 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanhesteren
force-pushed
the
support-rails-7-2
branch
from
911e8ad
to
2920f07
Compare
in the exception_handling module
svanhesteren
changed the title
svanhesteren
force-pushed
the
support-rails-7-2
branch
from
a95b673
to
3dd9553
Compare
skatkov
approved these changes
Sep 12, 2024
| exception_wrapper = ActionDispatch::ExceptionWrapper.new(backtrace_cleaner, e) | ||
| # ExceptionWrapper.show? contains the logic that chooses to pass exceptions through or not based on the | ||
| # `Rails.application.config.action_dispatch.show_exceptions` setting of :none, :rescuable and :all | ||
| raise e unless exception_wrapper.show?(http_request) |
skatkov
reviewed
Sep 12, 2024
.ruby-version
Outdated
| @@ -1 +1 @@ | |||
| 3.3.0 | |||
| 3.3.3 | |||
There was a problem hiding this comment.
thought: do we really need .ruby-version in a gem's source code? Can we yank this file?
There was a problem hiding this comment.
Prob. Most of our codebases have it. But not all. Added multi version testing.
skatkov
reviewed
Sep 12, 2024
| @@ -7,6 +7,7 @@ | |||
| ActiveRecord::Migrator.migrations_paths = [File.expand_path("../test/dummy/db/migrate", __dir__)] | |||
| require "rails/test_help" | |||
| require "rails/test_unit/reporter" | |||
| require "pry" | |||
There was a problem hiding this comment.
thought: do we really need pry here for debugging? Would binding.irb be enough?
In pbbuilder, for example, irb doesn't work. But for this gem we can easily debug without pry.
There was a problem hiding this comment.
Sure yanked it out.
in favor of multi version testing
svanhesteren
force-pushed
the
support-rails-7-2
branch
2 times, most recently
from
b7fdba4
to
7e03168
Compare
svanhesteren
force-pushed
the
support-rails-7-2
branch
from
7e03168
to
a9a9c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for rails 7.1 by fixing the deprecation of
request.show_exceptions?. Now this is controlled byRails.application.config.action_dispatch.show_exceptions.NOTE: Wil merge this after the pbbuilder merge, so we can import the gem instead of the github code directly.