Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to checkstyle 7.6.1 #93

Closed
romani opened this issue Mar 26, 2017 · 2 comments
Closed

upgrade to checkstyle 7.6.1 #93

romani opened this issue Mar 26, 2017 · 2 comments
Assignees
@romani
Labels
approved
Milestone
3.6.1

Comments

@romani
Copy link
Member

romani commented Mar 26, 2017

http://checkstyle.sourceforge.net/releasenotes.html#Release_7.6.1 ,

upgrade version at https://github.com/checkstyle/sonar-checkstyle/edit/master/pom.xml#L88
@romani romani self-assigned this Mar 28, 2017
romani added a commit that referenced this issue Mar 28, 2017
@romani
Issue #93: upgrade to checkstyle 7.6.1
26f3397
@romani romani mentioned this issue Mar 28, 2017
Closed
@romani
Copy link
Member Author

romani commented Apr 8, 2017 •
edited
Loading

upgrade notes:

  1. For Checks NoLineWrap and ParenPad, new default tokens has to be added manually by user to Sonar configuration, as Sonar store defaults as exact list.

After upgrade user will need to reactivate "PackageDeclaration" , as previous rule will be disabled, see picture below. That is expected as Check got new property so now user should configure it before usage.
screenshot-upgrade-tocheckstyle-7 6 1-package-declaration

romani added a commit that referenced this issue Apr 8, 2017
@romani
Issue #93: upgrade to checkstyle 7.6.1
313982f
@romani romani added this to the 3.7 milestone Apr 8, 2017
@romani
Copy link
Member Author

romani commented Apr 8, 2017

fix is merged

@romani romani closed this as completed Apr 8, 2017
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#93: upgrade to checkstyle 7.6.1
ca35ef0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romani romani

Labels
approved
Projects
None yet
Milestone
3.6.1
Development

No branches or pull requests
2 participants
@romani @rnveach