Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply checkstyle IntelijIdea inspection config, setup Teamcity validation #49

Closed
romani opened this issue Dec 23, 2016 · 3 comments
Closed

apply checkstyle IntelijIdea inspection config, setup Teamcity validation #49

romani opened this issue Dec 23, 2016 · 3 comments
Labels
approved
Milestone
3.8

Comments

@romani
Copy link
Member

romani commented Dec 23, 2016

  1. apply checkstyle's IntelijIdea inspection config
  2. setup Teamcity to validate master and PRs
romani added a commit that referenced this issue Dec 28, 2016
@romani
Issue #49: config files were copied from checkstyle repo
2e99ac8
romani added a commit that referenced this issue Dec 28, 2016
@romani
Issue #49: TC badge was added
8f3d2c0
@romani
Copy link
Member Author

romani commented Dec 28, 2016

limits are set to 66 errors and 48 warnings to avoid build failures on legacy code now.

romani added a commit that referenced this issue Jan 24, 2017
@romani
Issue #49: fix for 'Missing semicolon'
977bff1
@romani romani mentioned this issue Feb 11, 2017
Closed
marschall added a commit to marschall/sonar-checkstyle that referenced this issue Feb 11, 2017
@marschall
Issue checkstyle#49: Reduce rule violations
0f22ed3 
Fix various rule violations reported by Teamcity.
marschall added a commit to marschall/sonar-checkstyle that referenced this issue Feb 11, 2017
@marschall
Issue checkstyle#49: Reduce rule violations
1734711 
Fix various rule violations reported by Teamcity.
@marschall marschall mentioned this issue Feb 11, 2017
Merged
romani pushed a commit that referenced this issue Feb 11, 2017
@marschall @romani
Issue #49: Reduce rule violations
2cab030 
Fix various rule violations reported by Teamcity.
@romani
Copy link
Member Author

romani commented May 26, 2017

https://teamcity-support.jetbrains.com/hc/en-us/requests/998200

to resolve false positives on "Unused imports"

romani added a commit that referenced this issue May 26, 2017
@romani
Issue #49: resolve inspection violation for deprecated html tag - tt
5d4bfb6
romani added a commit that referenced this issue May 29, 2017
@romani
Issue #49: resolve/suppress few inspection violations
b3fa84f
romani added a commit that referenced this issue May 29, 2017
@romani
Issue #49: update for scope file to make it more clear that it does n…
d269b9e 
…ot work for TeamCity
romani added a commit that referenced this issue May 29, 2017
@romani
Issue #49: extend violations for PackageNamingConvention to avoid vio…
542ee33 
…lations
romani added a commit that referenced this issue Jun 6, 2017
@romani
Issue #49: disablement of few fules as problem on TC is not going to …
fc63880 
…be resolved quickly
romani added a commit that referenced this issue Jun 6, 2017
@romani
Issue #49: disablement of few fules as problem on TC is not going to …
65db8c8 
…be resolved quickly
romani added a commit that referenced this issue Jun 6, 2017
@romani
Issue #49: disable unused imports inspection
3fa8f1e
@romani romani added this to the 3.8 milestone Jun 6, 2017
@romani romani added the approved label Jun 6, 2017
@romani
Copy link
Member Author

romani commented Jun 6, 2017

0 errors and warnings.
Issue is resolved.

@romani romani closed this as completed Jun 6, 2017
romani added a commit that referenced this issue Jun 7, 2017
@romani
Revert "Issue #49: disablement of few fules as problem on TC is not g…
f494e9a 
…oing to be resolved quickly"

This reverts commit 65db8c8.
romani added a commit that referenced this issue Jun 7, 2017
@romani
Revert "Issue #49: disable unused imports inspection"
d7cfcc3 
This reverts commit 3fa8f1e.
@romani romani mentioned this issue Jun 7, 2017
Merged
romani added a commit that referenced this issue Jun 7, 2017
@romani
Revert "Issue #49: disablement of few fules as problem on TC is not g…
d7a68c9 
…oing to be resolved quickly"

This reverts commit 65db8c8.
romani added a commit that referenced this issue Jun 7, 2017
@romani
Revert "Issue #49: disable unused imports inspection"
96fa938 
This reverts commit 3fa8f1e.
@romani romani mentioned this issue Dec 26, 2018
Closed
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#49: config files were copied from checkstyle repo
8fe002e
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#49: TC badge was added
1bfb73e
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#49: fix for 'Missing semicolon'
2abb149
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@marschall @tsjensen
Issue checkstyle#49: Reduce rule violations
c98c67c 
Fix various rule violations reported by Teamcity.
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#49: resolve inspection violation for deprecated html…
cca19c5 
… tag - tt
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#49: resolve/suppress few inspection violations
7cb0acc
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#49: update for scope file to make it more clear that…
4828972 
… it does not work for TeamCity
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#49: extend violations for PackageNamingConvention to…
58348e7 
… avoid violations
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#49: disablement of few fules as problem on TC is not…
e799ab5 
… going to be resolved quickly
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#49: disable unused imports inspection
5b592c2
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Revert "Issue checkstyle#49: disablement of few fules as problem on T…
6a9b57e 
…C is not going to be resolved quickly"

This reverts commit 65db8c8.
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Revert "Issue checkstyle#49: disable unused imports inspection"
2b12e08 
This reverts commit 3fa8f1e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
3.8
Development

No branches or pull requests
1 participant
@romani