Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert maven-checkstyle-plugin run to ant run #444

Closed
rnveach opened this issue Oct 23, 2022 · 2 comments
Closed

Convert maven-checkstyle-plugin run to ant run #444

rnveach opened this issue Oct 23, 2022 · 2 comments
Labels

Comments

@rnveach
Copy link
Member

rnveach commented Oct 23, 2022

Similar to checkstyle/contribution#273 and checkstyle/checkstyle#5385 ,

We need to deprecate all usage of maven-checkstyle-plugin so we can start implementing backward breaking changes.

There should be no breaking change here as main repo does not do regression on this repo.

@rnveach
Copy link
Member Author

rnveach commented Oct 23, 2022

It appears Checkstyle may not be running on all files expected.

[INFO] [checkstyle] Running Checkstyle 10.0 on 35 files
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:63:5: 'Logger' instance should not have 'static' modifier. [AvoidModifiersForTypes]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:107:9: try/catch either requires a fail at the end of the try clause for junit tests or to remove the try/catch completely. [RequireFailForTryCatchInJunit]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:126:45: The String "admin" appears 2 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:127:48: The String "admin" appears 2 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:224:27: The String "language" appears 2 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:224:39: The String "java" appears 3 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:225:35: The String "checkstyle" appears 3 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:239:44: The String "java" appears 3 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:240:31: The String "profile_key" appears 2 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:241:47: The String "checkstyle" appears 3 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:255:35: The String "profile_key" appears 2 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:272:27: The String "language" appears 2 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:272:39: The String "java" appears 3 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\it\java\org\checkstyle\plugins\sonar\RunPluginTest.java:273:42: The String "checkstyle" appears 3 times in the file. [MultipleStringLiteralsExtended]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\test\java\org\sonar\plugins\checkstyle\CheckstyleRulesDefinitionTest.java:74:28: Lambda can be replaced with method reference. [PreferMethodReference]
[ERROR] [checkstyle] [ERROR] sonar-checkstyle\src\test\java\org\sonar\plugins\checkstyle\CheckstyleRulesDefinitionTest.java:78:28: Lambda can be replaced with method reference. [PreferMethodReference]

@rnveach
Copy link
Member Author

rnveach commented Oct 23, 2022

Fix was merged

@rnveach rnveach closed this as completed Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants