Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to checkstyle 8.4 #129

Closed
romani opened this issue Oct 29, 2017 · 1 comment
Closed

upgrade to checkstyle 8.4 #129

romani opened this issue Oct 29, 2017 · 1 comment
Labels
approved
Milestone
4.4

Comments

@romani
Copy link
Member

romani commented Oct 29, 2017 •
edited
Loading

http://checkstyle.sourceforge.net/releasenotes.html#Release_8.4 ,
upgrade version at https://github.com/checkstyle/sonar-checkstyle/edit/master/pom.xml#L88

Breaking backward compatibility:

Disallowing user to use incomplete fully qualified Check names in config file. 
JavadocTokenTypes should keep values of tokens, restore tokens as they were at 8.1 version. 
Remove extra numeric offset in JavadocTokenTypes.
romani added a commit that referenced this issue Dec 29, 2017
@romani
Issue #129: upgrade to checkstyle 8.4
60a6d03
@romani romani added this to the 4.4 milestone Dec 29, 2017
@romani
Copy link
Member Author

romani commented Dec 29, 2017

no updated are required for plugin.

@romani romani closed this as completed Dec 29, 2017
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#129: upgrade to checkstyle 8.4
351a913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
1 participant
@romani