Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to checkstyle 8.0 #117

Closed
romani opened this issue Jul 2, 2017 · 1 comment
Closed

upgrade to checkstyle 8.0 #117

romani opened this issue Jul 2, 2017 · 1 comment
Labels
Milestone

Comments

@romani
Copy link
Member

romani commented Jul 2, 2017

http://checkstyle.sourceforge.net/releasenotes.html#Release_8.0 ,
upgrade version at https://github.com/checkstyle/sonar-checkstyle/edit/master/pom.xml#L88

Migration notes:
If EmptyBlock Check was used with option='stmt', after update plugin there will be an error like:
[ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.2:sonar (default-cli) on project checkstyle-sonar-plugin-parent: Can not execute Checkstyle: cannot initialize module TreeWalker - Cannot set property 'option' to 'stmt' in module EmptyBlock: InvocationTargetException: unable to parse stmt: No enum constant com.puppycrawl.tools.checkstyle.checks.blocks.BlockOption.STMT -> [Help 1]
To fix problem set option=statement

@romani
Copy link
Member Author

romani commented Dec 18, 2017

MethodCountCheck: add ANNOTATION_DEF to toknes to avoid NPE

updated

api changes: make getAcceptableTokens/getRequiredTokens/getDefaultTokens methods as abstract in Check.java.
deprecate Checker.setClassloader , replace with Checker.setClassLoader.
Remove deprecated Check class.
CheckstyleAntTask: substitude setConfig(File) with setConfig(String).
remove deprecated getFilename menthod from FileContents

not affected.

rename STMT in BlockOption class to STATEMENT

updated

Remove unnecessary text from Javadoc tokens
Cache conflict between Maven/Ant and Eclipse/CLI run

not affected.

romani added a commit that referenced this issue Dec 18, 2017
@romani romani closed this as completed Dec 18, 2017
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant