Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for ParameterNumber max is missing #105

Closed
marschall opened this issue May 6, 2017 · 3 comments
Closed

Default value for ParameterNumber max is missing #105

marschall opened this issue May 6, 2017 · 3 comments
Milestone

Comments

@marschall
Copy link
Contributor

Sonar version: 5.6.5
Checkstyle sonar plugin verson: 3.6.1

Steps to reproduce or description of problem:

Create an SonarQube quality profile by importing the following Checkstyle configuration

<module name="Checker">
    <module name="TreeWalker">
        <module name="ParameterNumber"/>
    </module>
</module>

The import fails because no value for the max property is supplied. This should work because max property has a default value of 7

http://checkstyle.sourceforge.net/config_sizes.html#ParameterNumber

@romani
Copy link
Member

romani commented May 6, 2017

@marschall , it sound like all Checks parameters should have default value....
We have a lot of case where param withtout default value in rules.xml . Are all of this a problematic ?

@romani romani added this to the 3.7 milestone May 6, 2017
@romani
Copy link
Member

romani commented May 6, 2017

fix is merged

@romani romani closed this as completed May 6, 2017
@marschall
Copy link
Contributor Author

@romani no only if ones with default values should have the same default value in the rules.xml

tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants