Issue #71: fix Violation at sonarqube.com

This commit fixes #71 the violation at sonarqube.com. It removes a redundant null check.
checkstyle · Feb 12, 2017 · baad1ea · baad1ea
1 parent 7e813f6
commit baad1ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/checkstyle-sonar-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleExecutor.java b/checkstyle-sonar-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleExecutor.java
@@ -112,12 +112,10 @@ private void executeWithClassLoader(URLClassLoader projectClassloader) {
 
   @VisibleForTesting
   static void close(Closeable closeable) {
-    if (closeable != null) {
-      try {
-        closeable.close();
-      } catch (IOException e) {
-        throw new IllegalStateException("failed to close object", e);
-      }
+    try {
+      closeable.close();
+    } catch (IOException e) {
+      throw new IllegalStateException("failed to close object", e);
     }
   }
 

diff --git a/...style-sonar-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java b/...style-sonar-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java
@@ -151,11 +151,6 @@ public void canGenerateXmlReportNull() throws CheckstyleException {
     Assert.assertFalse(report.exists());
   }
 
-  @Test
-  public void closeNull() {
-    CheckstyleExecutor.close(null);
-  }
-
   @Test
   public void closeNoException() throws IOException {
     Closeable closeable = mock(Closeable.class);