Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Header for all Java Files #454

Open
rnveach opened this issue Jan 27, 2023 · 3 comments
Open

Enforce Header for all Java Files #454

rnveach opened this issue Jan 27, 2023 · 3 comments
Assignees
Labels

Comments

@rnveach
Copy link
Member Author

rnveach commented Jan 27, 2023

I think we should use the following:

//============================================================================
//
// Copyright (C) 2003-2023 the original author or authors.
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
// License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
// Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public
// License along with this library; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
//
//============================================================================

Git history started in May 2003.
No more names, since people change all the time.
It is similar to checkstyle, but is slightly different which I think is ok.

@romani
Copy link
Member

romani commented Jan 27, 2023

Yes, main point is no names on file header.
I am ok with proposal.

@Bananeweizen
Copy link
Collaborator

That is illegal. The copyright notice cannot be changed to just remove the original author. That would violate the LGPL itself, because it requires to include the original copyright notice. The Checkstyle project is neither author nor owner of those sources (it just uses a copy of the file under LGPL). Even in case of transferring all legally transferable rights to the project (like it's done in many larger open source foundations), the copyright would still be with the person who wrote it.
It's fine to check that all files have a license declaration, and that it is formatted identically, but the copyright line(s) must be excluded from that check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants