Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crit/stats): add const for dump and restore #93

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

snprajwal
Copy link
Member

@snprajwal snprajwal commented Sep 6, 2022

Closes #92
PTAL @adrianreber @rst0git

@codecov-commenter
Copy link

Codecov Report

Merging #93 (be1c695) into master (c54aaf7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   51.38%   51.38%           
=======================================
  Files           2        2           
  Lines         288      288           
=======================================
  Hits          148      148           
  Misses        105      105           
  Partials       35       35           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@adrianreber adrianreber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rst0git if you agree, please also make a 6.2.0 release.

Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rst0git rst0git merged commit 74ddb08 into checkpoint-restore:master Sep 6, 2022
@snprajwal snprajwal deleted the stats-const branch April 10, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

const stats.StatsDump stats.StatsRestore missing
4 participants