chore(magicgen): migrate script to Python #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rst0git
reviewed
Jun 27, 2024
snprajwal
force-pushed
the
port-magicgen-script
branch
from
e3bd4e4 to
9f98736
Compare
rst0git
reviewed
Jul 16, 2024
snprajwal
force-pushed
the
port-magicgen-script
branch
from
9f98736 to
022db02
Compare
rst0git
reviewed
Jul 16, 2024
The old script was in Go, and naively split the lines by whitespace to identify the magic names and values. The new Python script uses a proper regex rule to parse the input and generate the output. Signed-off-by: Prajwal S N <[email protected]>
snprajwal
force-pushed
the
port-magicgen-script
branch
from
022db02 to
76a006a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 49.38% 50.13% +0.74%
==========================================
Files 22 21 -1
Lines 2359 1889 -470
==========================================
- Hits 1165 947 -218
+ Misses 1058 810 -248
+ Partials 136 132 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old script was in Go, and naively split the lines by whitespace to identify the magic names and values. The new Python script uses a proper regex rule to parse the input and generate the output.
Fixes #176