-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: synchronise proto bindings with the latest version of CRIU RPC p… #137
Conversation
@rst0git can you review PR? |
Did you sync the changes from the CRIU release branch or criu-dev? |
I sync the changes from the criu-dev branch. |
Do you need those changes? I think we try to stay on the release branches of CRIU and not the criu-dev branch (if not necessary). |
The master branch of criu seems to have had some changes. You can update the commit with the new bindings by running |
I need these changes to be able to use these flags in the runc checky runc) point/restore process. (support for flags in runc will be followed bpoint/restore process. (support for flags in runc will be pushed in runc) |
Unfortunately, these changes are not included in the CRIU master branch |
Works for me. With all the changes currently going on we will not create a release in the next couple of weeks, but I think we can merge this. @rst0git PTAL |
@yevzman-swe Note that to use the go-criu changes with runc, you would need to install CRIU from the |
Signed-off-by: Yan Evzman <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
=======================================
Coverage 50.34% 50.34%
=======================================
Files 24 24
Lines 2590 2590
=======================================
Hits 1304 1304
Misses 1102 1102
Partials 184 184 ☔ View full report in Codecov by Sentry. |
rpc: synchronise proto bindings with the latest version of CRIU RPC