ci: fix protoc-gen-go path for go install #114
Conversation
|
I seem to be facing the same issue as your other PR that changed the Go version. Not sure why code coverage is failing since I haven't changed any of the commands in the CI pipeline :/ |
|
Independent of the CI failure, you should not include additional cosmetic changes in the same commit at least. |
|
Got it, let me split these out into a separate commit |
snprajwal
force-pushed
the
fix-protoc-gen-go
branch
from
02a1621 to
4ac2ef7
Compare
|
It seems Go 1.20 added support for merging multiple coverage reports using |
|
Coverage tests are fixed. Please rebase. |
The CI job that installed protoc-gen-go was using a deprecated package path. It has been updated with the path to the active package path. Signed-off-by: Prajwal S N <[email protected]>
Signed-off-by: Prajwal S N <[email protected]>
snprajwal
force-pushed
the
fix-protoc-gen-go
branch
from
4e8aaa9 to
51b1809
Compare
|
Thanks for fixing it! |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 18.72% 18.72%
=======================================
Files 93 93
Lines 15081 15081
=======================================
Hits 2824 2824
Misses 11979 11979
Partials 278 278 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
The CI job that installed protoc-gen-go was using a deprecated package path. It has been updated with the path to the active package path.
cc @rst0git