pstree: when updating sid for shell job also update matching pgid #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snorch
force-pushed
the
pstree-fix-sid-and-pgid-replacing
branch
2 times, most recently
from
ffc2574 to
57049d0
Compare
rst0git
reviewed
Jan 27, 2022
Codecov Report
@@ Coverage Diff @@
## criu-dev #1730 +/- ##
============================================
+ Coverage 70.68% 70.72% +0.04%
============================================
Files 127 127
Lines 30960 30986 +26
============================================
+ Hits 21885 21916 +31
+ Misses 9075 9070 -5
Continue to review full report at Codecov.
|
If we replace old_sid with current_sid we should also do same replacement for matching pgid (=old_sid). Reported in CRIU gitter by Younes Manton (@ymanton) Signed-off-by: Pavel Tikhomirov <[email protected]>
Snorch
force-pushed
the
pstree-fix-sid-and-pgid-replacing
branch
from
57049d0 to
7876124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we replace old_sid with current_sid we should also do same
replacement for matching pgid (=old_sid).
Reported in CRIU gitter by Younes Manton (@ymanton)
Signed-off-by: Pavel Tikhomirov [email protected]