3.16.1 release #1624
Merged
3.16.1 release #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 394 recommends changing python shebangs to python3 when Python 3.x is supported. This is similar to `crit-python3`. https://www.python.org/dev/peps/pep-0394/ Signed-off-by: Radostin Stoyanov <[email protected]>
Python 2 has been deprecated since January 1, 2020 and linux distributions already support Python 3. Thus, to simplify maintenance and packaging we could support criu-ns as Python 3 only. v2: Add a message for criu-ns installation Signed-off-by: Radostin Stoyanov <[email protected]>
In runc we use the join-ns RPC API to enable checkpoint/restore of containers with shared namespaces. Shared namespaces are often used when containers run inside Kubernetes Pod. In crun we use libcriu to interface with CRIU, however it currently doesn't provide an API for join-ns. This patch adds the necessary libcriu API to enable checkpoint/restore of containers with shared namespaces with crun. Signed-off-by: Radostin Stoyanov <[email protected]>
Replace magic numbers used to set log level in libcriu with constants. Signed-off-by: Radostin Stoyanov <[email protected]>
This test case aims to verify that CRIU correctly restores a process in IPC, UTS and Time namespaces with criu_join_ns_add() libcriu API. Signed-off-by: Radostin Stoyanov <[email protected]>
run_test was trying to read criu logs on build failure instead of runtime error. This patch also removes the unnecessary subfolder with name "i" and resolves some of issues reported by shellcheck. Signed-off-by: Radostin Stoyanov <[email protected]>
Signed-off-by: Radostin Stoyanov <[email protected]>
Just for reference, in crun we check the version of criu to find out if |
avagin
approved these changes
Oct 6, 2021
0x7f454c46
approved these changes
Oct 6, 2021
|
LGTM |
xemul
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (@rst0git and myself) would like to see a 3.16.1 release with the following two changes:
criu-ns--join-nsvia libcriuThe versioned python interpreter is a change which is necessary for our binary packages provided via OBS, COPR, Fedora and PPA. RPMs as well as DEBs are not happy with an unversioned python interpreter in
criu-ns. We have workarounds but having the fix in 3.16.1 would be cleaner.The main reason for this .1 release is, however, the
--join-nssupport in libcriu. To support checkpointing container out of pods and restoring into different pods we need to be able to join existing namespaces. This option is exported via CLI and RPC but not via libcriu. To add pod support to crun this release is needed as crun uses libcriu as an interface. It is easier for upstream crun to depend on a released version instead of the latest built from thecriu-devbranch. As there are usually 8 to 10 months between CRIU releases we would like to see the--join-nsvia libcriu released as soon as possible to be able to use crun.CC: @checkpoint-restore/maintainers
We can also pull additional patches from
criu-devif it would be useful in a 3.16.1 release.