kdat: make kerndat_uffd differentiate -EPERM and -1 from uffd_open #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I'm not sure this is a best way to fix it, probable se should just add "int *err" argument to uffd_open to return errno... Please feel free to give an advice. |
rppt
reviewed
May 31, 2021
xemul
requested changes
Jun 1, 2021
Previousely kerndat_uffd could not differentiate -EPERM and -1 returned from uffd_open(). That way "Failed to get uffd API" and "Incompatible uffd API ..." errors were just ignored, which is probably not what we want. v2: rework with extra argument of uffd_open for errno, rename err label in uffd_open for readability Fixes: cfdeac4 ("kerndat: Handle non-root mode when checking uffd") Signed-off-by: Pavel Tikhomirov <[email protected]>
Snorch
force-pushed
the
kdat-fix-usage-of-uffd_open
branch
from
22a2c4a to
960fe12
Compare
rppt
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Else "Failed to get uffd API" and "Incompatible uffd API ..." errors are
just ignored, which is probably not what we want.
Fixes: cfdeac4 ("kerndat: Handle non-root mode when checking uffd")
Signed-off-by: Pavel Tikhomirov [email protected]