Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golang 1.20 for binary test code coverage #44

Merged

Conversation

adrianreber
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +10.58 🎉

Comparison is base (586a9f1) 63.92% compared to head (6517f80) 74.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #44       +/-   ##
===========================================
+ Coverage   63.92%   74.50%   +10.58%     
===========================================
  Files           3        3               
  Lines         255      255               
===========================================
+ Hits          163      190       +27     
+ Misses         69       51       -18     
+ Partials       23       14        -9     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adrianreber adrianreber requested a review from rst0git April 14, 2023 12:20
@adrianreber adrianreber mentioned this pull request Apr 14, 2023
Makefile Outdated Show resolved Hide resolved
@rst0git
Copy link
Member

rst0git commented Apr 14, 2023

@adrianreber It might be good to add .coverage/ and checkpointctl.coverage to gitignore

@adrianreber adrianreber force-pushed the 2023-04-14-coverage branch from 8dd1e25 to 6517f80 Compare April 14, 2023 15:02
@adrianreber
Copy link
Member Author

@adrianreber It might be good to add .coverage/ and checkpointctl.coverage to gitignore

added

@adrianreber adrianreber requested a review from rst0git April 14, 2023 15:43
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianreber adrianreber merged commit 86e9400 into checkpoint-restore:main Apr 14, 2023
@adrianreber adrianreber deleted the 2023-04-14-coverage branch April 14, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants