Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional container metadata from containerd #135

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

adrianreber
Copy link
Member

containerd structures the internal metadata differently. For a restore the status.dump file is also necessary.

Copy link

github-actions bot commented Jun 17, 2024

Test Results

55 tests  ±0   55 ✅ ±0   1s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 29b1087. ± Comparison against base commit 46361c3.

♻️ This comment has been updated with latest results.

containerd structures the internal metadata differently. For a restore
the status.dump file is also necessary.

The status.dump file contains the content of:

  crictl inspect <CTR-ID> | jq ".status"

and the information is needed during restore to get container
annotations and metadata. CRI-O in contrast has this data available
as metadata in config.dump. As containerd has this information somewhere
else it needs to be saved during checkpointing for a successful restore.

Signed-off-by: Adrian Reber <[email protected]>
@adrianreber adrianreber force-pushed the 2024-06-17-stats-dump branch from 0c8ab70 to 29b1087 Compare June 17, 2024 17:13
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rst0git rst0git merged commit 1d224fa into checkpoint-restore:main Jun 17, 2024
10 checks passed
@adrianreber adrianreber deleted the 2024-06-17-stats-dump branch June 19, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants