metadata: Add DevShmCheckpointTar #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Podman is running a container in private IPC mode (default), it creates a bind mount for /dev/shm that is attached to a tmpfs folder on the host file system. However, checkpointing a container has the side-effect of stopping that container and unmount the tmpfs used for /dev/shm. As a result, after checkpoint all files stored in the container's /dev/shm would be lost and the container restore might fail. To address this problem, this commit defines a metadata tar file that could be used to store the content of /dev/shm, include it in the container checkpoint, and restore it. Signed-off-by: Radostin Stoyanov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 4 4
Lines 589 589
=======================================
Hits 342 342
Misses 210 210
Partials 37 37
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Podman is running a container in private IPC mode (default), it creates a bind mount for
/dev/shmthat is attached to a tmpfs folder on the host file system. However, checkpointing a container has the side-effect of stopping that container and unmount the tmpfs used for/dev/shm. As a result, after checkpoint all files stored in the container's/dev/shmwould be lost and the container restore might fail.To address this problem, this commit defines a metadata tar file that could be used to store the content of
/dev/shm, include it in the container checkpoint, and restore it.