Simplified 'list' command code #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for the 'list' command introduced code which already existed in the repository. This commit re-uses existing code. Also, this extends the 'list' command to get the information from checkpoints created by containerd. This also changes how the 'list' command works. Before it was always using '/var/lib/kubelet/checkpoints/' to look for checkpoints and '-p' extended the search path. Now 'checkpoint list' looks in the default location and 'checkpoint list /tmp /etc' only looks in '/tmp/' and '/etc', but no longer in the default location. Always looking in the default location broke local tests for me. Signed-off-by: Adrian Reber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for the 'list' command introduced code which already existed in the repository. This commit re-uses existing code.
Also, this extends the 'list' command to get the information from checkpoints created by containerd.
This also changes how the 'list' command works. Before it was always using '/var/lib/kubelet/checkpoints/' to look for checkpoints and '-p' extended the search path. Now 'checkpoint list' looks in the default location and 'checkpoint list /tmp /etc' only looks in '/tmp/' and '/etc', but no longer in the default location. Always looking in the default location broke local tests for me.
I am combining tests and code changes in a single commit as the changes are breaking the tests.
@Parthiba-Hazra The main reason I did the changes was that the information was not correctly displayed for the checkpoint archives as created by containerd.