test: add e2e test for json format #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @Parthiba-Hazra |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
===========================================
+ Coverage 62.96% 78.72% +15.76%
===========================================
Files 7 7
Lines 1161 1161
===========================================
+ Hits 731 914 +183
+ Misses 388 185 -203
- Partials 42 62 +20 ☔ View full report in Codecov by Sentry. |
rst0git
force-pushed
the
json-test
branch
2 times, most recently
from
be1844e to
3e517e2
Compare
snprajwal
approved these changes
Jan 11, 2024
|
I see a coverage of 20% of |
Not necessarily. I will update the patch to extend the test coverage. |
rst0git
force-pushed
the
json-test
branch
5 times, most recently
from
f5feb90 to
fc0687e
Compare
|
@adrianreber I've updated the pull request to increase test coverage. |
adrianreber
reviewed
Jan 15, 2024
adrianreber
reviewed
Jan 15, 2024
Environment variables with empty values (e.g., "FOO=") are valid. Signed-off-by: Radostin Stoyanov <[email protected]>
Signed-off-by: Radostin Stoyanov <[email protected]>
Add support for command-line options to the piggie process. This would allow us to extend the functionality with additional options (e.g., tcp-socket). Signed-off-by: Radostin Stoyanov <[email protected]>
This patch extends the 'piggie' test process with TCP client/server that allows to improve the test coverage of checkpointctl inspect. The iptables and iproute packages are needed for network locking and to configure network namespace. Signed-off-by: Radostin Stoyanov <[email protected]>
Add e2e tests to verify the JSON output of `checkpointctl inspect`. Signed-off-by: Radostin Stoyanov <[email protected]>
Signed-off-by: Radostin Stoyanov <[email protected]>
adrianreber
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a test case that verifies the output JSON format for checkpointctl.