fix: prevent duplicate entries with overlapping block_ranges #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to create duplicate entires that would apply within the same block that would have single ID. That shouldn't be the case, ID is not longer unique in whole table, but should be within single block_range.
bonustrack
reviewed
Oct 9, 2024
| @@ -205,6 +205,10 @@ export class GqlEntityController { | |||
| public async createEntityStores(knex: Knex): Promise<{ builder: Knex.SchemaBuilder }> { | |||
| let builder = knex.schema; | |||
|
|
|||
| if (knex.client.config.client === 'pg') { | |||
There was a problem hiding this comment.
Do we support other db than Postgres? Or what is this condition for?
There was a problem hiding this comment.
At the moment just for our tests as those run with SQLite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to create duplicate entires that would apply within the same block that would have single ID.
That shouldn't be the case, ID is not longer unique in whole table, but should be within single block_range.