Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/4.3.3 into main #524

Merged
merged 7 commits into from
Apr 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ All notable changes to this project will be documented in this file.

#### 4.x Releases

## [4.3.3](https://github.com/checkout/frames-ios/releases/tag/4.3.3)

Released on 2024-04-04

Updates:

- Included a Correlation ID enhancement in our logging.


## [4.3.2](https://github.com/checkout/frames-ios/releases/tag/4.3.2)

Released on 2024-03-01
Expand Down
32 changes: 26 additions & 6 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,17 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
destination: "platform=iOS Simulator,name=iPhone 15 Pro,OS=latest"
configuration: "Debug"
noIndex: "COMPILER_INDEX_STORE_ENABLE=NO"
noSigning: "CODE_SIGNING_ALLOWED=NO"
versionXcode: "15.2"

jobs:
analyze:
name: Analyze
runs-on: [ macos-latest ]
runs-on: [ macos-13-large ]
permissions:
actions: read
contents: read
Expand All @@ -45,24 +52,37 @@ jobs:
with:
languages: ${{ matrix.language }}
queries: security-and-quality


- name: Select Xcode
run: |
sudo xcode-select -switch /Applications/Xcode_${versionXcode}.app

- name: Log xcodebuild Version
run: |
xcodebuild -version


- name: Build Frames
run: |
xcodebuild -scheme Frames -destination "platform=iOS Simulator,name=iPhone 14 Pro,OS=latest"
xcodebuild -scheme Frames -destination "${destination}" "${noIndex}" "${noSigning}" | xcpretty

- name: Build CheckoutTests
run: |
xcodebuild build -scheme CheckoutTests -destination "${destination}" "${noIndex}" "${noSigning}" | xcpretty

- name: Build FramesTests
run: |
xcodebuild -scheme FramesTests -destination "platform=iOS Simulator,name=iPhone 14 Pro,OS=latest" test
xcodebuild build -scheme FramesTests -destination "${destination}" "${noIndex}" "${noSigning}" | xcpretty

- name: Build iOS Example Frame SPM
run: |
cd iOS\ Example\ Frame\ SPM
xcodebuild build -scheme iOS\ Example\ Frame -destination "platform=iOS Simulator,name=iPhone 14 Pro,OS=latest"
xcodebuild build -scheme iOS\ Example\ Frame -destination "${destination}" "${noIndex}" "${noSigning}" | xcpretty

- name: Build UITest
run: |
cd iOS\ Example\ Frame\ SPM
xcodebuild -scheme UITest -destination "platform=iOS Simulator,name=iPhone 14 Pro,OS=latest"
xcodebuild -scheme UITest -destination "${destination}" "${noIndex}" "${noSigning}" | xcpretty

# Perform analysis on the code
- name: Analyze code with CodeQL
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/publish-Checkout.podspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Check current branch
run: |
if [[ "${GITHUB_REF#refs/heads/}" != "main" && "${GITHUB_REF#refs/heads/}" != release/* ]]; then
echo "This workflow is expected to run on the main or release branch only."
exit 1
fi
# - name: Check current branch
# run: |
# if [[ "${GITHUB_REF#refs/heads/}" != "main" && "${GITHUB_REF#refs/heads/}" != release/* ]]; then
# echo "This workflow is expected to run on the main or release branch only."
# exit 1
# fi

- name: Publish Checkout.podspec
run: |
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/publish-Frames.podspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Check current branch
run: |
if [[ "${GITHUB_REF#refs/heads/}" != "main" && "${GITHUB_REF#refs/heads/}" != release/* ]]; then
echo "This workflow is expected to run on the main or release branch only."
exit 1
fi
# - name: Check current branch
# run: |
# if [[ "${GITHUB_REF#refs/heads/}" != "main" && "${GITHUB_REF#refs/heads/}" != release/* ]]; then
# echo "This workflow is expected to run on the main or release branch only."
# exit 1
# fi

- name: Publish Frames.podspec
run: |
Expand Down
11 changes: 10 additions & 1 deletion .swiftpm/xcode/xcshareddata/xcschemes/CheckoutTests.xcscheme
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "NO"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "NO">
Expand Down Expand Up @@ -53,6 +53,15 @@
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "CheckoutTests"
BuildableName = "CheckoutTests"
BlueprintName = "CheckoutTests"
ReferencedContainer = "container:">
</BuildableReference>
</MacroExpansion>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
Expand Down
25 changes: 25 additions & 0 deletions .swiftpm/xcode/xcshareddata/xcschemes/FramesTests.xcscheme
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "FramesTests"
BuildableName = "FramesTests"
BlueprintName = "FramesTests"
ReferencedContainer = "container:">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
Expand Down Expand Up @@ -42,6 +58,15 @@
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "FramesTests"
BuildableName = "FramesTests"
BlueprintName = "FramesTests"
ReferencedContainer = "container:">
</BuildableReference>
</MacroExpansion>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
Expand Down
4 changes: 2 additions & 2 deletions Checkout.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'Checkout'
s.version = '4.3.2'
s.version = '4.3.3'
s.summary = 'Checkout SDK for iOS'

s.description = <<-DESC
Expand All @@ -20,6 +20,6 @@ Pod::Spec.new do |s|
s.exclude_files = "Checkout/Samples/**"

s.dependency 'CheckoutEventLoggerKit', '~> 1.2.4'
s.dependency 'Risk', '2.0.1'
s.dependency 'Risk', '2.0.3'

end
2 changes: 1 addition & 1 deletion Checkout/Samples/CocoapodsSample/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ target 'CheckoutCocoapodsSample' do
use_frameworks!

# Pods for CheckoutSDKCocoapodsSample
pod 'Checkout', '4.3.2'
pod 'Checkout', '4.3.3'

end
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@
repositoryURL = "https://github.com/checkout/frames-ios";
requirement = {
kind = exactVersion;
version = 4.3.2;
version = 4.3.3;
};
};
/* End XCRemoteSwiftPackageReference section */
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion Checkout/Source/Tokenisation/CheckoutAPIService.swift
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ final public class CheckoutAPIService: CheckoutAPIProtocol {
riskEnvironment = .sandbox
}

let riskConfig = RiskConfig(publicKey: publicKey, environment: riskEnvironment, framesMode: true)
let riskConfig = RiskConfig(publicKey: publicKey, environment: riskEnvironment, framesMode: true, correlationId: logManager.correlationID)
let riskSDK = Risk.init(config: riskConfig)

logManager.setup(
Expand Down
2 changes: 1 addition & 1 deletion Checkout/Source/Validation/Constants.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public enum Constants {
}

enum Product {
static let version = "4.3.2"
static let version = "4.3.3"
static let name = "checkout-ios-sdk"
static let userAgent = "checkout-sdk-ios/\(version)"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ final class CheckoutAPIServiceIntegrationTests: XCTestCase {

// details associated with default apple pay token
let expectedApplePayDetails = ApplePayDetails(
expiryDate: try! CardValidator(environment: .sandbox).validate(expiryMonth: 3, expiryYear: 24).get(),
expiryDate: .init(month: 3, year: 2024),
bin: "537426",
last4: "7789"
)
Expand Down
4 changes: 2 additions & 2 deletions Frames.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "Frames"
s.version = "4.3.2"
s.version = "4.3.3"
s.summary = "Checkout API Client, Payment Form UI and Utilities in Swift"
s.description = <<-DESC
Checkout API Client and Payment Form Utilities in Swift.
Expand All @@ -21,6 +21,6 @@ Pod::Spec.new do |s|

s.dependency 'PhoneNumberKit'
s.dependency 'CheckoutEventLoggerKit', '~> 1.2.4'
s.dependency 'Checkout', '4.3.2'
s.dependency 'Checkout', '4.3.3'

end
4 changes: 2 additions & 2 deletions Package.resolved
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/checkout/checkout-risk-sdk-ios.git",
"state" : {
"revision" : "4823f05166dca8392a41b56b975515c7e0f1a8da",
"version" : "2.0.1"
"revision" : "a5df46ecd4324661459faa9e9ac18d627b4d26aa",
"version" : "2.0.3"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ let package = Package(
exact: "3.5.9"),
.package(
url: "https://github.com/checkout/checkout-risk-sdk-ios.git",
exact: "2.0.1"),
exact: "2.0.3"),
.package(
url: "https://github.com/checkout/checkout-event-logger-ios-framework.git",
from: "1.2.4"
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/Constants/Constants.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
enum Constants {

static let productName = "frames-ios-sdk"
static let version = "4.3.2"
static let version = "4.3.3"
static let userAgent = "checkout-sdk-frames-ios/\(version)"

enum Logging {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1239,7 +1239,7 @@
repositoryURL = "https://github.com/checkout/frames-ios";
requirement = {
kind = exactVersion;
version = 4.3.2;
version = 4.3.3;
};
};
16C3F83E2A7927ED00690639 /* XCRemoteSwiftPackageReference "swift-snapshot-testing" */ = {
Expand Down
Loading
Loading