[Frames-iOS] - Allow billing address to be disabled on the prebuilt UI #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashna-narula-cko
force-pushed
the
aashna/PIMOB-2358-disable_billing_address
branch
from
8fb5472 to
32e0455
Compare
ehab-al-cko
reviewed
Jan 18, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aashna-narula-cko
force-pushed
the
aashna/PIMOB-2358-disable_billing_address
branch
from
fd74f76 to
ebdb219
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
okhan-okbay-cko
requested changes
Jan 18, 2024
There was a problem hiding this comment.
- UI Tests are being run on the already released Frames v 4.3.0
- Sample apps are being built on the same
We need to be sure to run them on the new code that's being provided with this PR. The way to do it is to fetch the SPM package and the pod from aashna/PIMOB-2358-disable_billing_address.
okhan-okbay-cko
approved these changes
Jan 18, 2024
aashna-narula-cko
force-pushed
the
aashna/PIMOB-2358-disable_billing_address
branch
from
e266517 to
c814b9d
Compare
aashna-narula-cko
deleted the
aashna/PIMOB-2358-disable_billing_address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
An SDK integrator is able to disable the billing address on the prebuilt UI. Currently they can only do this via the customisable UIs. When they disable the billing address, it doesn’t show on the prebuilt UI
Issue ticket number and link.
PIMOB-2358
Proposed changes
Make billingFormStyle optional which will be checked against while creating default views.
Test Steps
If there's any functionality change, please list a step by step guide of how to verify the changes, and/or upload a screen recording for any visible changes.