Add regression tests flow #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhan-okbay-cko
force-pushed
the
feature/check-pr-workflow
branch
17 times, most recently
from
6eece4d to
5d76e6c
Compare
okhan-okbay-cko
changed the base branch from
feature/check-pr-workflow
to
main
okhan-okbay-cko
force-pushed
the
feature/regression-tests-workflow
branch
from
d30f4a0 to
7f9092c
Compare
okhan-okbay-cko
force-pushed
the
feature/regression-tests-workflow
branch
10 times, most recently
from
c942f07 to
7ee94b6
Compare
okhan-okbay-cko
force-pushed
the
feature/regression-tests-workflow
branch
2 times, most recently
from
ed923e0 to
53615b1
Compare
okhan-okbay-cko
force-pushed
the
feature/regression-tests-workflow
branch
3 times, most recently
from
91dbb8b to
192e8df
Compare
okhan-okbay-cko
force-pushed
the
feature/regression-tests-workflow
branch
from
192e8df to
f904da8
Compare
ehab-al-cko
reviewed
Sep 6, 2023
ehab-al-cko
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capability to run regression tests on a ad-hoc and on demand basis. JIRA
There are changes about
perceptualPrecision. Everyone had the same problem.> 0.98match is not detectable by human eye so it's safe and recommended way to use. It's automatically set in the extensions.This PR also includes the lowering of the deployment target. Otherwise we couldn't get the simulator list for regression tests.
Snapshots had to be updated because otherwise they were not passing even after a perceptual precision change, even the changes were visibly not perceivable. So, the current images are produced on CI, uploaded as an artifact and then added to the repo as a new source of truth.
Images, side by side, need to be given a second-eye, to see if they look the same as before. If you witness any perceivable difference, then please add a review comment.