Add request telemetry for go sdk #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @sanchayata-jain-cko, I will review it asap |
armando-rodriguez-cko
changed the base branch from
master
to
beta/add-telemetry-by-sanchayata-jain-cko
|
Thank you @sanchayata-jain-cko I will check it in a beta branch |
armando-rodriguez-cko
merged commit f669aba
into
checkout:beta/add-telemetry-by-sanchayata-jain-cko
| @@ -216,6 +216,20 @@ The execution of integration tests require the following environment variables s | |||
| * For default account systems (OAuth): `CHECKOUT_DEFAULT_OAUTH_CLIENT_ID` & `CHECKOUT_DEFAULT_OAUTH_CLIENT_SECRET` | |||
| * For Previous account systems (ABC): `CHECKOUT_PREVIOUS_PUBLIC_KEY` & `CHECKOUT_PREVIOUS_SECRET_KEY` | |||
|
|
|||
| ## Telemetry | |||
| Request telementry is enabled by default in the Go SDK. Request latency is included in the telemetry data. Recording the request latency allows Checkout.com to continuously monitor and imporove the merchant experience. | |||
There was a problem hiding this comment.
Should we add a note saying the information is sent back in the header? That would make it clear that the SDK is not using any additional resources (e.g. making another HTTP call) to pass back the telemetry data
armando-rodriguez-cko
pushed a commit
that referenced
this pull request
Nov 20, 2024
* adding telemetry for requests * add test for request metrics queue * tidied test * give option to enable telemetry in invoke function as well * add integration test for telemetry * seperate sending http request into seperate function * add readme for telemetry * fixed formatting in readme * fixed whitespace
armando-rodriguez-cko
pushed a commit
that referenced
this pull request
Nov 21, 2024
* adding telemetry for requests * add test for request metrics queue * tidied test * give option to enable telemetry in invoke function as well * add integration test for telemetry * seperate sending http request into seperate function * add readme for telemetry * fixed formatting in readme * fixed whitespace
armando-rodriguez-cko
added a commit
that referenced
this pull request
Nov 21, 2024
* adding telemetry for requests * add test for request metrics queue * tidied test * give option to enable telemetry in invoke function as well * add integration test for telemetry * seperate sending http request into seperate function * add readme for telemetry * fixed formatting in readme * fixed whitespace Co-authored-by: sanchayata-jain-cko <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measures and adds request latency telemetry by default
Users can opt-out of measuring telemetry