Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add holidays for Reunion #46

Merged
1 commit merged into from
Feb 10, 2020
Merged

Add holidays for Reunion #46

1 commit merged into from
Feb 10, 2020

Conversation

julienmru
Copy link
Contributor

Please consider merging this PR to add support for Reunion holidays

@wandersonwhcr
Copy link
Contributor

Is this a province or state from France?

If yes, IMHO, we must create or change FR class and include a state parameter, like BR or DE.

@julienmru
Copy link
Contributor Author

julienmru commented Feb 10, 2020

Dear @wandersonwhcr, it is an overseas territory, a part of France but with its own ISO country code, IDD, domain name extension, etc. It's located East coast of Madagascar.

When you ship to Reunion from other countries, you need to specify 'Reunion' as a country and not 'France'.

So I guess it's really up to your policy but most libraries handle Reunion as a specific country, eg. giggsey/libphonenumber-for-php.

@wandersonwhcr
Copy link
Contributor

@julienmru TY

Copy link
Contributor

@wandersonwhcr wandersonwhcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong here :)

@ghost ghost merged commit 8cb739d into checkdomain:master Feb 10, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants