Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name #815

Merged
merged 9 commits into from
Aug 25, 2020

Conversation

flacatus
Copy link
Collaborator

What does this PR do?

This PR check if CRD are up to date verifying the number of properties and check CRD versions.
This Pr also create cluster roles and role binding using namespace name..

What issues does this PR fix or reference?

eclipse-che/che#14419

…ter roles and cluster rolebindings

Signed-off-by: flacatus <[email protected]>
Signed-off-by: flacatus <[email protected]>
@flacatus flacatus changed the title Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name feat: Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name Aug 19, 2020
src/api/kube.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
@flacatus flacatus changed the title feat: Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name [WIP] Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name Aug 19, 2020
src/api/kube.ts Outdated Show resolved Hide resolved
Signed-off-by: flacatus <[email protected]>
@flacatus flacatus changed the title [WIP] Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name feat: Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name Aug 20, 2020
Signed-off-by: flacatus <[email protected]>
@tolusha
Copy link
Collaborator

tolusha commented Aug 21, 2020

looks good to me.
Let's finish testing...

src/tasks/installers/operator.ts Outdated Show resolved Hide resolved
src/api/kube.ts Outdated Show resolved Hide resolved
Signed-off-by: flacatus <[email protected]>
@flacatus flacatus merged commit 2fca137 into che-incubator:master Aug 25, 2020
@che-bot che-bot added this to the 7.18 milestone Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants