-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter roles and cluster rolebindings Signed-off-by: flacatus <[email protected]>
Signed-off-by: flacatus <[email protected]>
flacatus
requested review from
AndrienkoAleksandr,
l0rd,
mmorhun and
tolusha
as code owners
August 19, 2020 10:51
flacatus
changed the title
Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name
feat: Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name
Aug 19, 2020
tolusha
reviewed
Aug 19, 2020
tolusha
reviewed
Aug 19, 2020
tolusha
reviewed
Aug 19, 2020
tolusha
reviewed
Aug 19, 2020
tolusha
reviewed
Aug 19, 2020
tolusha
reviewed
Aug 19, 2020
tolusha
reviewed
Aug 19, 2020
flacatus
changed the title
feat: Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name
[WIP] Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name
Aug 19, 2020
… add improves to CRD checks Signed-off-by: flacatus <[email protected]>
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
tolusha
reviewed
Aug 20, 2020
Signed-off-by: flacatus <[email protected]>
flacatus
changed the title
[WIP] Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name
feat: Ensure CRD are up to date and create cluster roles and cluster role binding using namespace unique name
Aug 20, 2020
tolusha
reviewed
Aug 21, 2020
Signed-off-by: flacatus <[email protected]>
looks good to me. |
mmorhun
reviewed
Aug 21, 2020
58 tasks
Signed-off-by: flacatus <[email protected]>
mmorhun
approved these changes
Aug 25, 2020
tolusha
approved these changes
Aug 25, 2020
tolusha
reviewed
Aug 25, 2020
tolusha
reviewed
Aug 25, 2020
tolusha
reviewed
Aug 25, 2020
tolusha
reviewed
Aug 25, 2020
Signed-off-by: flacatus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR check if CRD are up to date verifying the number of properties and check CRD versions.
This Pr also create cluster roles and role binding using namespace name..
What issues does this PR fix or reference?
eclipse-che/che#14419