fix: Improve getPodReadyConditionStatus #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <[email protected]>
tolusha
requested review from
AndrienkoAleksandr,
l0rd and
mmorhun
as code owners
56 tasks
tolusha
changed the title
tolusha
changed the title
AndrienkoAleksandr
approved these changes
May 25, 2020
mmorhun
reviewed
May 25, 2020
Signed-off-by: Anatoliy Bazko <[email protected]>
mmorhun
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko [email protected]
What does this PR do?
Sometimes pod
statusmight not containconditionof typeReady.It is better to return
underfinefor getPodReadyConditionStatus and allows other function to wait and getconditionin the next request.What issues does this PR fix or reference?
eclipse-che/che#17001