Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify '--domain' parameter in server:start command #613

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Apr 1, 2020

Signed-off-by: Mykola Morhun [email protected]

What does this PR do?

Adds clarification to --domain parameter of server:start command.
Adds warning message if --domain parameter is used with Openshift family infrastructures.

What issues does this PR fix or reference?

eclipse-che/che#14404
eclipse-che/che#16003

@tolusha
Copy link
Collaborator

tolusha commented Apr 1, 2020

@mmorhun
What about testing availability in case domain is defined?

@mmorhun
Copy link
Contributor Author

mmorhun commented Apr 1, 2020

@tolusha could you be more specific about "testing availability" ?

@tolusha
Copy link
Collaborator

tolusha commented Apr 1, 2020

@mmorhun
For instance, user specified domain:
chectl server:start --domain x.x.x.x.nip.io
does it make sense to ping x.x.x.x.nip.io to check it availability ?

@mmorhun mmorhun self-assigned this Apr 1, 2020
@mmorhun
Copy link
Contributor Author

mmorhun commented Apr 1, 2020

Ok, will do the check, makes sense.

@tolusha tolusha mentioned this pull request Apr 1, 2020
43 tasks
@mmorhun mmorhun merged commit 722db07 into master Apr 1, 2020
@mmorhun mmorhun deleted the che-14404 branch April 1, 2020 14:40
@mmorhun
Copy link
Contributor Author

mmorhun commented Apr 1, 2020

@tolusha I've added the domain check in a separate PR: #615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants