-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Eclipse Che deploy / update flow #1082
Conversation
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
…can be deployed with chectl Signed-off-by: Mykola Morhun <[email protected]>
Skipping CI for Draft Pull Request. |
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
@@ -479,12 +482,18 @@ OPTIONS | |||
-t, --templates=templates | |||
Path to the templates folder | |||
|
|||
-v, --version=version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's odd because I might expect that -v or --version will display the current version of the cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag is used as an argument for server:deploy
command, so it will not collide with -v
flag of chectl
itself.
Signed-off-by: Mykola Morhun <[email protected]>
Signed-off-by: Mykola Morhun <[email protected]>
What does this PR do?
This PR contains several changes:
chectl
is able to deploy embedded (the same as cli) version of Che and all (with some limitations) previous versions.version
flag toserver:deploy
command, that downloads templates for older versions. For future versions, update ofchectl
is required (so far the limitation is UX not technical).chectl
is available. Forserver:deploy
andserver:update
commands interactive prompt is added.minishift-addon
.What issues does this PR fix or reference?
eclipse-che/che#18022
How to test this PR?
--version
flag with different installers.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.