Print meaningful error message when user tries to delete a running wo…

…rkspace (#806)

Signed-off-by: Anatolii Bazko <[email protected]>

src/api/che.ts

@@ -547,14 +547,17 @@ export class CheHelper {
   async getWorkspace(cheUrl: string, workspaceId: string, accessToken = ''): Promise<any> {
     const endpoint = `${cheUrl}/api/workspace/${workspaceId}`
     const headers: any = { 'Content-Type': 'text/yaml' }
-    if (accessToken && accessToken.length > 0) {
+    if (accessToken) {
       headers.Authorization = `${accessToken}`
     }
 
     try {
       const response = await this.axios.get(endpoint, { headers })
       return response.data
     } catch (error) {
+      if (error.response.status === 404) {
+        throw new Error(`Workspace ${workspaceId} not found. Please use the command workspace:list to get list of the existed workspaces.`)
+      }
       throw this.getCheApiError(error, endpoint)
     }
   }
@@ -572,8 +575,10 @@ export class CheHelper {
     try {
       await this.axios.delete(endpoint, { headers })
     } catch (error) {
-      if (error.response.status === 409) {
-        throw new Error(`Workspace '${workspaceId}' not found`)
+      if (error.response.status === 404) {
+        throw new Error(`Workspace ${workspaceId} not found. Please use the command workspace:list to get list of the existed workspaces.`)
+      } else if (error.response.status === 409) {
+        throw new Error('Cannot delete a running workspace. Please stop it using the command workspace:stop and try again')
       }
       throw this.getCheApiError(error, endpoint)
     }
@@ -629,7 +634,7 @@ export class CheHelper {
     return fileName
   }
 
-  private getCheApiError(error: any, endpoint: string): Error {
+  getCheApiError(error: any, endpoint: string): Error {
     if (error.response) {
       const status = error.response.status
       if (status === 403) {

src/commands/workspace/delete.ts

@@ -56,6 +56,7 @@ export default class Delete extends Command {
     tasks.add(cheTasks.verifyCheNamespaceExistsTask(flags, this))
     tasks.add(cheTasks.retrieveEclipseCheUrl(flags))
     tasks.add(cheTasks.checkEclipseCheStatus())
+
     tasks.add({
       title: `Get workspace by id '${args.workspace}'`,
       task: async (ctx, task) => {

yarn.lock

@@ -1544,11 +1544,11 @@ ecc-jsbn@~0.1.1:
 
 "eclipse-che-operator@git://github.com/eclipse/che-operator#master":
   version "0.0.0"
-  resolved "git://github.com/eclipse/che-operator#c4a3ff2480740190f97feb3e6c85029506561e8c"
+  resolved "git://github.com/eclipse/che-operator#c64d61faf4f7b5eb13ee1d91e0ee90c8a84b3b8c"
 
 "eclipse-che@git://github.com/eclipse/che#master":
   version "0.0.0"
-  resolved "git://github.com/eclipse/che#593f91515f368dc6d76e1f09113e4d61c562aa46"
+  resolved "git://github.com/eclipse/che#cc7fd4e75e45e632e3d8f704ac2d0ce8365e55ce"
 
 editorconfig@^0.15.0:
   version "0.15.3"