Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update from ubi8/nodejs-18:1-71 to ubi8/nodejs-18:1-81 #305

Merged
merged 8 commits into from
Nov 21, 2023
Merged

chore: Update from ubi8/nodejs-18:1-71 to ubi8/nodejs-18:1-81 #305

merged 8 commits into from
Nov 21, 2023

Conversation

che-incubator-bot
Copy link
Collaborator

Signed-off-by: Nick Boldt [email protected]

@openshift-ci-robot
Copy link

@che-incubator-bot: No Jira issue with key nodejs-18 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Signed-off-by: Nick Boldt [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2023 •
edited
Loading

Click here to review and test in web IDE: Contribute

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Nov 20, 2023 •
edited
Loading

I tried to rerun failed jobs few times, but they permanently fail with the error:

image

azatsarynnyy
azatsarynnyy reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update of UBI from ubi8/nodejs-18:1-71 to ubi8/nodejs-18:1-81
updates Node.js from 18.16.1 to 18.18.2
which updates npm from 9.5.1 to 9.8.1

It seems they're not bundling node-gyp-bin with npm since 9.8.1. Now, it's up to the consumers to provide the required node-gyp version.
I suggest fixing it by something like npm i -g [email protected]

@azatsarynnyy
Copy link
Member

BTW, the same problem is in #306 which was merged to 7.77.x
@nickboldt could you please either revert it ^^ or install the node-gyp globally into the image?

@github-actions GitHub Actions
Copy link

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-305-dev-amd64

@azatsarynnyy
Copy link
Member

I've pushed the changes that I think should fix the problem. If it works for main I can back-port it to 7.77.x

@github-actions GitHub Actions
Copy link

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-305-dev-amd64

RomanNikitenko
RomanNikitenko reviewed Nov 20, 2023
View reviewed changes
build/dockerfiles/linux-libc.Dockerfile Outdated
@@ -47,7 +47,8 @@ RUN { if [[ $(uname -m) == "s390x" ]]; then LIBSECRET="\
fi; } \
&& yum install -y $LIBSECRET $LIBKEYBOARD curl make cmake gcc gcc-c++ python3.9 git git-core-doc openssh less libX11-devel libxkbcommon bash tar gzip rsync patch \
&& yum -y clean all && rm -rf /var/cache/yum \
&& npm install -g [email protected]
&& npm install -g [email protected] \
&& npm install -g [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azatsarynnyy @nickboldt
I guess the same changes are required for the downstream

@github-actions GitHub Actions
Copy link

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-305-amd64

@nickboldt
Copy link
Contributor

nickboldt commented Nov 20, 2023 •
edited
Loading

It would be better to actually include node-gyp in the package.json since that's what I'll need downstream. yarn add doesn't work in an offline environment like OSBS/cachito. But adding deps to the package.json and pinning them in yarn.lock... that DOES work in both online and offline scenarios.

WDYT of this? 6645ca6 and https://github.com/che-incubator/che-code/pull/305/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@nickboldt
add node gyp 9.4.1 as a dep; add node/npm/yarn versions as engines
6645ca6 
Change-Id: I2f7bd96e2fa240ad6161fdb4b1826c4669a66dff
Signed-off-by: nickboldt <[email protected]>
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@nickboldt
Add node-gyp to yarn.lock
3af326a 
Change-Id: I4314882f4fc4cc8f3a4535d912a9b762edb55356
Signed-off-by: nickboldt <[email protected]>
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
2 similar comments
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@RomanNikitenko RomanNikitenko mentioned this pull request Nov 21, 2023
Merged
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
RomanNikitenko
RomanNikitenko reviewed Nov 21, 2023
View reviewed changes
build/dockerfiles/linux-libc.Dockerfile Outdated
@@ -47,8 +47,7 @@ RUN { if [[ $(uname -m) == "s390x" ]]; then LIBSECRET="\
fi; } \
&& yum install -y $LIBSECRET $LIBKEYBOARD curl make cmake gcc gcc-c++ python3.9 git git-core-doc openssh less libX11-devel libxkbcommon bash tar gzip rsync patch \
&& yum -y clean all && rm -rf /var/cache/yum \
&& npm install -g [email protected] \
&& npm install -g [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like removing this change leads to the original problem...
I mean - just adding the dependency to the package.json doesn't fix the problem

Copy link
Contributor

@nickboldt nickboldt Nov 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put it back ... let's see if the build passes.

https://github.com/che-incubator/che-code/actions/runs/6947262890/job/18900655734?pr=305

@RomanNikitenko RomanNikitenko mentioned this pull request Nov 21, 2023
Merged
9 tasks
@github-actions GitHub Actions
Copy link

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-305-dev-amd64

@nickboldt nickboldt enabled auto-merge (squash) November 21, 2023 18:32
@github-actions GitHub Actions
Copy link

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-305-amd64

@nickboldt nickboldt merged commit 3a2d784 into main Nov 21, 2023
6 checks passed
@nickboldt nickboldt deleted the pr-update-base-images-1700267676 branch November 21, 2023 18:33
@devstudio-release
Copy link

Build 3.11 :: code_3.x/1011: Console, Changes, Git Data

nickboldt added a commit that referenced this pull request Nov 21, 2023
@che-incubator-bot @nickboldt @azatsarynnyy
chore: Update from ubi8/nodejs-18:1-71 to ubi8/nodejs-18:1-81 (#305)
bfa1576 
* chore: Update from ubi8/nodejs-18:1-71 to ubi8/nodejs-18:1-81

Signed-off-by: Nick Boldt <[email protected]>

* install node-gyp globally

* Update linux-libc.Dockerfile

* Update build/dockerfiles/linux-libc.Dockerfile

* add node gyp 9.4.1 as a dep; add node/npm/yarn versions as engines

Change-Id: I2f7bd96e2fa240ad6161fdb4b1826c4669a66dff
Signed-off-by: nickboldt <[email protected]>

* Add node-gyp to yarn.lock

Change-Id: I4314882f4fc4cc8f3a4535d912a9b762edb55356
Signed-off-by: nickboldt <[email protected]>

* remove node-gyp global install

* Revert "remove node-gyp global install"

This reverts commit c39f3c2.

---------

Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: nickboldt <[email protected]>
Co-authored-by: Nick Boldt <[email protected]>
Co-authored-by: Artem Zatsarynnyi <[email protected]>
Co-authored-by: nickboldt <[email protected]>
@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5340: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5208: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: push-latest-container-to-quay_3.x/3726: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5208: SUCCESS

code : 3.x :: Build 57113174 : quay.io/devspaces/code-rhel8:3.11-29
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3726 triggered

@devstudio-release
Copy link

Build 3.11 :: code_3.x/1011: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5340 triggered

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/4969: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2307: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5342: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5210: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: push-latest-container-to-quay_3.x/3727: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5210: SUCCESS

devspaces-operator-bundle : 3.x :: Build 57115825 : quay.io/devspaces/devspaces-operator-bundle:3.11-82
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3727 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.11-29
- quay.io/devspaces/configbump-rhel8:3.11-6
- quay.io/devspaces/dashboard-rhel8:3.11-26
- quay.io/devspaces/devfileregistry-rhel8:3.11-16
- quay.io/devspaces/devspaces-rhel8-operator:3.11-10
- quay.io/devspaces/idea-rhel8:3.11-5
- quay.io/devspaces/pluginregistry-rhel8:3.11-6
- quay.io/devspaces/server-rhel8:3.11-15
- quay.io/devspaces/traefik-rhel8:3.11-4
- quay.io/devspaces/udi-rhel8:3.11-8
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202311021630.p0.gb17014f.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202311021630.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5342: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5210 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2307: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5342 triggered

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2177: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/4969: SUCCESS

Detected new images: rebuild operator-bundle
* code; /DS_CI/operator-bundle_3.x/2307 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1573: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1573: SUCCESS

3.11.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanNikitenko RomanNikitenko RomanNikitenko approved these changes

@azatsarynnyy azatsarynnyy azatsarynnyy left review comments

@nickboldt nickboldt nickboldt approved these changes

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy vitaliy-guliy is a code owner

@l0rd l0rd Awaiting requested review from l0rd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@che-incubator-bot @openshift-ci-robot @RomanNikitenko @azatsarynnyy @nickboldt @devstudio-release