Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODIM-6787- Load all subscription information's to cache #66

Merged
merged 19 commits into from
Jan 19, 2023
Merged

ODIM-6787- Load all subscription information's to cache #66

merged 19 commits into from
Jan 19, 2023

Conversation

chauberahul1993
Copy link
Owner

No description provided.

Bharath-KKB
Bharath-KKB reviewed Jan 9, 2023
View reviewed changes
Copy link

@Bharath-KKB Bharath-KKB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix as per comments

svc-events/events/subscriptionCache.go Outdated Show resolved Hide resolved
svc-events/events/subscriptionCache.go Outdated Show resolved Hide resolved
svc-events/events/subscriptionCache.go Outdated Show resolved Hide resolved
svc-events/events/subscriptionCache.go Show resolved Hide resolved
svc-events/events/subscriptionCache.go Outdated Show resolved Hide resolved
svc-events/events/subscriptionCache.go Outdated Show resolved Hide resolved
svc-events/events/subscriptionCache.go Outdated Show resolved Hide resolved
svc-events/events/subscriptionCache.go Show resolved Hide resolved
svc-events/events/subscriptionCache.go Show resolved Hide resolved
svc-events/events/subscriptionCache.go Outdated Show resolved Hide resolved
@chauberahul1993 chauberahul1993 changed the base branch from development to ODIM-6787 January 11, 2023 04:08
Bharath-KKB
Bharath-KKB reviewed Jan 11, 2023
View reviewed changes
Copy link

@Bharath-KKB Bharath-KKB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update as per all the comments and discuss the two files with me

lib-dmtf/model/events.go Outdated Show resolved Hide resolved
lib-dmtf/model/events.go Outdated Show resolved Hide resolved
svc-events/events/getevtsubscription.go Show resolved Hide resolved
svc-events/events/publishevttosubscriber.go Show resolved Hide resolved
@chauberahul1993 chauberahul1993 self-assigned this Jan 13, 2023
@chauberahul1993 chauberahul1993 added the enhancement New feature or request label Jan 13, 2023
@amar-shalgar amar-shalgar merged commit 6c180ec into ODIM-6787 Jan 19, 2023
@amar-shalgar amar-shalgar deleted the ODIM-6787_task3 branch January 19, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bharath-KKB Bharath-KKB Bharath-KKB left review comments

@sriteja-sabbineni sriteja-sabbineni sriteja-sabbineni approved these changes

@amar-shalgar amar-shalgar amar-shalgar approved these changes

@AngithCJ AngithCJ Awaiting requested review from AngithCJ

@hemkapoor hemkapoor Awaiting requested review from hemkapoor

@kavyamani596 kavyamani596 Awaiting requested review from kavyamani596

Assignees

@chauberahul1993 chauberahul1993

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chauberahul1993 @amar-shalgar @Bharath-KKB @sriteja-sabbineni