Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing property in MRR #107

Merged
merged 1 commit into from
May 22, 2023
Merged

Add missing property in MRR #107

merged 1 commit into from
May 22, 2023

Conversation

VincentLanglet
Copy link
Contributor

Hi @pkopac @sbrych,

I received tons of deprecations:

Deprecated: Creation of dynamic property ChartMogul\Metrics\MRR::$percentage_change is deprecated

According to the API reference the property $percentage_change exists
https://dev.chartmogul.com/reference/retrieve-mrr
So I added it to the class. It would be great if you have time to merge and release this. :)

I dunno if it was a miss or if the data was recently added to the API.
But if you're regularly adding new value in API response, you might want to add the #[AllowDynamicProperties] to the AbstractModel class in order to avoid any deprecations in the futur.

@VincentLanglet
Copy link
Contributor Author

Friendly ping @pkopac @sbrych, any time to take a look ? :)

@pkopac pkopac merged commit 755097d into chartmogul:main May 22, 2023
@pkopac
Copy link
Contributor

pkopac commented May 22, 2023

Hello @VincentLanglet! Thank you for the PR and sorry about the delay, I missed it completely until you pinged us. We'll look into adding AllowDynamicProperties it sounds useful.

@VincentLanglet
Copy link
Contributor Author

Hello @VincentLanglet! Thank you for the PR and sorry about the delay, I missed it completely until you pinged us. We'll look into adding AllowDynamicProperties it sounds useful.

No problem, I pinged just in case ^^ ; if you have time for a patch release it would be perfect for me.

@pkopac
Copy link
Contributor

pkopac commented May 22, 2023

@VincentLanglet 👍 https://github.com/chartmogul/chartmogul-php/releases/tag/v5.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants