Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Connect subscriptions [ch4619] #23

Conversation

hassansin
Copy link
Contributor

Added ConnectSubscription method: https://dev.chartmogul.com/reference#connect-subscriptions

example:

err := api.ConnectSubscriptions("cus_f466e33d-ff2b-4a11-8f85-417eb02157a7", []cm.Subscription{
	{
		ExternalID:     "d1c0c885-add0-48db-8fa9-0bdf5017d6b0",
		DataSourceUUID: "ds_ade45e52-47a4-231a-1ed2-eb6b9e541213",
	},
	{
		ExternalID:     "9db5f4a1-1695-44c0-8bd4-de7ce4d0f1d4",
		DataSourceUUID: "ds_ade45e52-47a4-231a-1ed2-eb6b9e541213",
	},
})

@pkopac pkopac changed the title Added method from Connect subscriptions [ch4619] Add Connect subscriptions [ch4619] Dec 18, 2018
Copy link
Contributor

@pkopac pkopac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set any expectations in the test after the connect subscriptions is called? I mean, what actually is the effect? I know we're supposed to test just the client library here, but just calling it and expecting no error seems to me kind of "unfinished".

@hassansin
Copy link
Contributor Author

@pkopac good point, I'm waiting for Vinay to provide me with more details about verifying the effect through API.

@hassansin hassansin merged commit 2b7a680 into master Dec 20, 2018
@hassansin hassansin deleted the hassansin/ch4619/go-support-for-connect-subscriptions-endpoint branch December 20, 2018 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants