Fix hover interaction animations #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag the render request as "lazy" so the controller can cancel it in order to correctly animate hover interactions. The 1ms duration is a workaround to make sure an animation is created so the controller can stop it before any transition. Also, verify if there is an active animation, in which case we don't need to explicitly call render().
|
@simonbrunel what do you think is the best way do testing here?
|
|
I think the easiest is to replace files in https://deploy-preview-119--chartjs-plugin-datalabels.netlify.com/chartjs-plugin-datalabels.js |
|
@simonbrunel okay cool. I'll test this today! |
|
Update: can't get to it today. ASAP! |
nagix
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag the render request as "lazy" so the controller can cancel it in order to correctly animate hover interactions. The 1ms duration is a workaround to make sure an animation is created so the controller can stop it before any transition. Also, verify if there is an "active" animation, in which case we don't need to explicitly call render().
@dutrieux @rpearce can you verify if these changes fix your issues?
@nagix what do you think about that workaround?
Fixes #108