Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small bugs when animations are disabled #8253

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Dec 30, 2020

Regressions related to issue #4991

  • When hovering same element after update and the event is replayed, lastActive and active have the same contents, but none of the elements have hover styles applied. => apply hover styles to all active elements in replayed event.

  • Animation.active is a function, it was used as a property in couple of places.

@etimberg etimberg merged commit 2e43f78 into chartjs:master Dec 30, 2020
@kurkle kurkle deleted the anim-bugs branch December 30, 2020 18:51
@kurkle kurkle mentioned this pull request Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants