Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove I prefix from TS types #8017

Merged
merged 8 commits into from
Nov 7, 2020

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Nov 6, 2020

Standardizes all of the typescript types to drop the I prefix. For example IEvent is now just Event.

The only non-standard change is IInteractionMode which changed to InteractionModeMap because InteractionMode was already defined.

@etimberg etimberg added breaking change type: types Typescript type changes labels Nov 6, 2020
@kurkle
Copy link
Member

kurkle commented Nov 6, 2020

[!] TypeError: Cannot destructure property column of 'undefined' or 'null'.

Something collides?

@etimberg
Copy link
Member Author

etimberg commented Nov 6, 2020

Perhaps, but the TSC lint works. On the command line I see circular errors, but I think those are pre-existing.

types/core/index.d.ts -> types/platform/index.d.ts -> types/core/index.d.ts
types/core/index.d.ts -> types/platform/index.d.ts -> types/core/interfaces.d.ts -> types/core/index.d.ts
types/controllers/index.d.ts -> types/core/index.d.ts -> types/platform/index.d.ts -> types/core/interfaces.d.ts -> types/interfaces.d.ts -> types/controllers/index.d.ts
...and 9 more

src/core/core.interaction.js Outdated Show resolved Hide resolved
src/core/core.layouts.js Outdated Show resolved Hide resolved
@etimberg
Copy link
Member Author

etimberg commented Nov 7, 2020

I got the build working locally. I think we'll need to investigate the linter, some of these should have been caught by that. There were two bad imports (IFontSpec and IChartArea) that VSCode rename symbol had missed. No idea why the linter didn't catch that. There was also a conflict definition of FillTarget and DateAdapter became recursive.

@etimberg etimberg merged commit 17f6edb into chartjs:master Nov 7, 2020
@etimberg etimberg deleted the update-ts-interface-names branch November 7, 2020 13:35
@etimberg etimberg added this to the Version 3.0 milestone Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants