Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update/draw only visible -regression #7808

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Fix: Update/draw only visible -regression #7808

merged 1 commit into from
Sep 20, 2020

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Sep 20, 2020 •
edited
Loading

Closes: #7803

  • Update all points when scale range changes and animations are enabled
  • When animations are enabled, include currently visible points in the drawing range. So any points going out of canvas are animated to do so.

Pen

@etimberg etimberg added this to the Version 3.0 milestone Sep 20, 2020
@etimberg etimberg merged commit 7633343 into chartjs:master Sep 20, 2020
@kurkle kurkle deleted the regression branch September 30, 2020 04:28
@jledentu jledentu mentioned this pull request Apr 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Regression when sliding scale min / max values after "[perf] Update/draw only visible line/points" commit
2 participants
@kurkle @etimberg