New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strong typings for scales and datasets in options #7791

Merged

etimberg merged 1 commit into chartjs:master from emmcb:scale-types

Sep 14, 2020

Contributor

emmcb commented Sep 13, 2020

More work on types.

Scales options are now strongly typed if containing the type property, else semi-strongly typed (cartesian options for cartesian charts, radial options for radial charts)
Added missing options[type].datasets, also strongly typed
More sensible default for data points: Chart will still default to unknown[], but for example Chart<'bubble'> will now default to BubbleDataPoint[]
Some refactor for registries

Screenshot, any non-valid property here will fail:


          Strong typings for scales and datasets in options

a7e432f

etimberg approved these changes

View reviewed changes

kurkle approved these changes

View reviewed changes

Member

kurkle left a comment

lgtm

etimberg merged commit b5853a4 into chartjs:master

etimberg added this to the Version 3.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet