Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3-beta][types] Improve types #7767

Merged
merged 11 commits into from
Sep 9, 2020
Merged

[v3-beta][types] Improve types #7767

merged 11 commits into from
Sep 9, 2020

Conversation

xr0master
Copy link
Contributor

PR for topic

  • improve type of generic chart type
  • improve type for the Chart update method arguments
  • allow to set/overwrite data an existing Chart instance
  • added plugins argument for the chart configuration

etimberg
etimberg previously approved these changes Sep 7, 2020
@etimberg etimberg merged commit 1ec6f1d into chartjs:master Sep 9, 2020
@etimberg etimberg added this to the Version 3.0 milestone Sep 9, 2020
@etimberg etimberg mentioned this pull request Sep 9, 2020
@santam85
Copy link

santam85 commented Sep 14, 2020

I am getting
ERROR: .../node_modules/chart.js/helpers/chunks/index.d.ts:1285:1 - error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

for declarations like:
enum UpdateModeEnum { resize = 'resize', reset = 'reset', none = 'none', hide = 'hide', show = 'show', normal = 'normal', active = 'active' }

I fixed it by adding declare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants