Issue 4991

[kurkle]

On top of #7080
This is quite big, I'll split if needed.

Closes: #4991

Master

pen for master

PR

pen for pr

[benmccann]

I'm not sure what happens if we declare only some of the types. That seems like it'd make it hard to use with DefinitelyTyped. I wonder if we want to hold off on that unless we can do them all. Maybe work on it in a separate branch if we want to go that way

[kurkle]

I'm not sure what happens if we declare only some of the types. That seems like it'd make it hard to use with DefinitelyTyped. I wonder if we want to hold off on that unless we can do them all. Maybe work on it in a separate branch if we want to go that way

We would need to add the types to release, to be usable. (Also I don't think the DefinitelyTyped spec works at all with v3, so if we have a place for them here, I bet we get PR's for them)

[kurkle]

removed the not needed changes.

[etimberg]

No objections to this. Agree on the doc comments that @benmccann had

[benmccann]

@kurkle this one will need to be rebased

[benmccann]

Can you explain more why the position from update might not be the final position?

[kurkle]

Element's properties are its current state ("view" in 2.9) and the animations contain the target ("model" in 2.9). So when animations are enabled, after update and before first animation frame, elements x/y are exactly the same than before update. Only the animations were updated. The Animator then updates the elements in each frame.

[benmccann]

Sorry for my delay on reviewing. Would you mind sharing an interactive example for this one? I want to play around and test a few things

[kurkle]

https://codepen.io/kurkle/pen/yLNJwJZ

[benmccann]

In the codepen, if I leave my mouse over a segment of the pie and then don't touch it, the tooltip just stays in the same place and doesn't update the value it's displaying despite the data changing

[kurkle]

In the codepen, if I leave my mouse over a segment of the pie and then don't touch it, the tooltip just stays in the same place and doesn't update the value it's displaying despite the data changing

Good catch! Fixed!

[benmccann]

I found a couple more issues:

• I left my mouse over Data 1 and it eventually popped over the border into Data 3
• I left my mouse on Data 3 and for awhile it was moving to realign with the center of the pie piece with each animation, but then it just stopped moving and froze where it was

[benmccann]

I saw you pushed a new commit. Now sure if you updated the codepen, but it's working the same for me

[kurkle]

I saw you pushed a new commit. Now sure if you updated the codepen, but it's working the same for me

I did update the pen. The code is in another pen though, so there could be caching.
Can you produce an animated gif of the issues, I can't seem to reproduce. I noticed a "pause" in moving when animations were finished when the update occurs (increasing the update interval to 2s made it obvious), and fixed that.

[kurkle]

Here's the same pen using master: https://codepen.io/kurkle/pen/MWwjvaw

[benmccann]

It seems to be working pretty well now though I did get one quirk. I'm not quite sure how to make an animated gif, but here's a screenshot of an instance where the tooltip was placed a bit oddly. I think that it may happen when the mouse is in Data 1, that segment gets a data value of 0 (now the mouse is in Data 2 as a result), and then the next update when it reappears in Data 1 it does so in an unexpected location.

[kurkle]

Additionally fixed the alignment, size and caret position of tooltip. Pen updated.

[benmccann]

If I just leave my mouse stationary over one of the segments, the tooltip no longer moves as it should when the segment sizes change (I was looking at https://codepen.io/kurkle/pen/MWwjvaw)

[kurkle]

If I just leave my mouse stationary over one of the segments, the tooltip no longer moves as it should when the segment sizes change (I was looking at https://codepen.io/kurkle/pen/MWwjvaw)

Look at the other pen, that one is how master works.

The one using this PR: https://codepen.io/kurkle/pen/yLNJwJZ

[benmccann]

Sorry about that and thanks for the correction

It looks pretty good. I tried to slow it down quite a bit to do some final checks. I was following docs/configuration/animations.md and changed the settings to the below settings. When I move my mouse in between segments the tooltip moves pretty quickly even though I'd expect it to take 4s to move based on my settings. Am I doing something wrong? I'm wondering if maybe the docs need to be updated or if the tooltip animation speed isn't using the settings as it should

Chart.defaults.animation.duration = 10000;
Chart.defaults.animation.active.duration = 4000;
window.setInterval(RefreshData, 15000);

[kurkle]

I filed a new issue about the animation documentation.
Here is a pen with the tooltip animation slowed down to 4000 too:
https://codepen.io/kurkle/pen/MWwJKxa

[benmccann]

The behavior in the pen all looks good to me. Just had a minor suggestion about adding some more explanation in the code. Thanks for the patience on this one

[benmccann]

Could you expand this comment a little? There's a lot going on here, so I just want to make sure I understand correctly.

I think the following is perhaps true:

• It's referring the final position after this update
• The event will have mouse coordinates from the last event. This should basically be where the mouse is currently

Why do we handle the event at the final position? Once the animation starts it will move it back to the initial position and then animate it back towards the final position?