Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show color box only on the first line of the tooltip body #6984

Merged
merged 2 commits into from
Jan 19, 2020
Merged

Show color box only on the first line of the tooltip body #6984

merged 2 commits into from
Jan 19, 2020

Conversation

etimberg
Copy link
Member

This makes multi line tooltips body much more usable.

Before

tooltip-before

After

tooltip-after

@etimberg etimberg added this to the Version 3.0 milestone Jan 18, 2020
kurkle
kurkle previously approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a lot better
I think alingment options are going to be requested, but thats another thing.

benmccann
benmccann reviewed Jan 19, 2020
View reviewed changes
src/core/core.tooltip.js Outdated Show resolved Hide resolved
kurkle
kurkle approved these changes Jan 19, 2020
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First version minified better, but maybe this is easier to gat

@etimberg etimberg merged commit 216ac70 into chartjs:master Jan 19, 2020
@etimberg etimberg deleted the tooltip-only-show-color-box-one-line branch January 19, 2020 14:03
@etimberg etimberg mentioned this pull request Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@etimberg @benmccann @kurkle