Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltip content and styling on update() #6635

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Update tooltip content and styling on update() #6635

merged 2 commits into from
Oct 29, 2019

Conversation

RatherLogical
Copy link
Contributor

@benmccann @kurkle @etimberg

This is a rebase of the PR: #6181 I really need this feature in Chart.js core.

kurkle
kurkle previously approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, not quite sure if it changes anything.
This could affect #6614 too.

src/core/core.tooltip.js Outdated Show resolved Hide resolved
@RatherLogical
Code consistency
0850d48 
Improved consistency with the similar code in core.controller.js (l. 1084)
@etimberg etimberg merged commit 50fd869 into chartjs:master Oct 29, 2019
@etimberg etimberg added this to the Version 3.0 milestone Oct 29, 2019
@benmccann benmccann mentioned this pull request Oct 29, 2019
Closed
@Evertvdw Evertvdw mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@RatherLogical @etimberg @kurkle @benmccann