Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use document when getRootNode is unsupported #6630

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Use document when getRootNode is unsupported #6630

merged 1 commit into from
Oct 29, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Oct 28, 2019

Fixes: #6629

benmccann
benmccann approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I think we need to create a 2.9 branch instead of merging this into master

@stockiNail
Copy link
Contributor

@benmccann I don't want to entry in your decision, but be aware that version 2.9.x is currently not working with IE and EDGE and I hope you can apply this update into the master as soon as possible.
THANK YOUU!

@benmccann
Copy link
Contributor

master is currently targeting 3.0, so I was suggesting we release this as a fix before then :-)

@andreme andreme mentioned this pull request Oct 28, 2019
Merged
@etimberg
Copy link
Member

Ok, so how should we handle this? I'm thinking:

  1. Merge to master
  2. Cherry pick the commit to the release branch
  3. Do the release process

@benmccann
Copy link
Contributor

That sounds good to me

@kurkle
Copy link
Member Author

kurkle commented Oct 29, 2019

Did another PR against 2.9 branch, would that be simpler?

@etimberg
Copy link
Member

Works for me

@etimberg etimberg merged commit 09bd524 into chartjs:master Oct 29, 2019
@andreme
Copy link

andreme commented Oct 30, 2019

@etimberg Thank you. Would you mind doing a release as well?

@kurkle kurkle deleted the get-root-node branch November 13, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IE/EDGE: Object doesn't support property or method 'getRootNode'
5 participants
@kurkle @stockiNail @benmccann @etimberg @andreme