Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for ES6 modules #6619

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Adds support for ES6 modules #6619

merged 1 commit into from
Oct 27, 2019

Conversation

sebiniemann
Copy link
Contributor

Adds support for ES6 builds and adds the semi-official module option to the package.json to advice bundlers to use the new builds whenever import is used.

Fixes #5179

@etimberg etimberg added this to the Version 3.0 milestone Oct 27, 2019
kurkle
kurkle approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really stop the bundling business. But that's another issue.

@etimberg
Copy link
Member

We can change that later in this release cycle

@etimberg etimberg merged commit 9537548 into chartjs:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Chart.js does not import as es6 module
4 participants
@sebiniemann @etimberg @kurkle @benmccann